CBG-4366 enable resurrection tests #7229
Merged
+144
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to use fewer buckets
gregns1
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM, I ran tests in goland and it feels much nicer having each subtest under each topology.
I was trying to think of a way to integrate the updatePeersT call into the test so whoever is writing a test wouldn't have to remember to do it (I would totally forget) but I'm not sure there is an easy way to do that so I'm good with it as is! 😄
bbrks
pushed a commit
that referenced
this pull request
Dec 5, 2024
bbrks
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch tests to use fewer buckets: for each topology use use one bucket and then each actor will run tests in sequence. Using subtests allows to run each test individually if necessary.
Need to update tb on each peer for each subtest to avoid
subtest may have called FailNow on a parent testerror.The integration tests can still fail but they don't seem to fail more frequently than the old code. I haven't seen failures in jenkins, but I might not have run them frequently enough.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2839/